Skip to content

modify ASF header for each file and add related maven plugin#4

Merged
jixuan1989 merged 6 commits intomasterfrom
fix_license
Jan 21, 2019
Merged

modify ASF header for each file and add related maven plugin#4
jixuan1989 merged 6 commits intomasterfrom
fix_license

Conversation

@jixuan1989
Copy link
Member

@jixuan1989 jixuan1989 commented Jan 19, 2019 •
edited
Loading

  • modify asf header for each file
  • enable apache-rat-plugin
  • add more exclusive files on apache-rat-plugin and license-maven-plugin, i.e., *.json, *.md, and *.csv

only 3 files (pom.xml, tsfile/pom.xml, and jdbc/pom.xml) are modified manually, all others are modified by program automatically.

So, reviewers need to review the 3 files.

1. modify asf header for each file; 2. enable apache-rat-plugin; 3. a…
691ffe4 
…dd more exclusive files on apache-rat-plugin and license-maven-plugin, i.e., *.json, *.md, and *.csv
@chrisdutz
Copy link
Contributor

chrisdutz commented Jan 19, 2019

you shouldn't exclude "*.md" files ... they are not binary and it's easy to add comments the normal xml style with ()

@jixuan1989
Copy link
Member Author

jixuan1989 commented Jan 19, 2019

you shouldn't exclude "*.md" files ... they are not binary and it's easy to add comments the normal xml style with ()

Hm... but it is strange if we add ASF header on a Readme.md file for readers...

I checked some other projects, their readme file or some other *.md files do not have the asf header.

e.g.,
https://github.com/apache/incubator-plc4x/blob/develop/README
https://github.com/apache/incubator-plc4x/blob/develop/DEVELOPMENT.md
https://github.com/apache/cassandra/blob/trunk/TESTING.md
https://github.com/apache/cassandra/blob/trunk/README.asc

@chrisdutz
Copy link
Contributor

chrisdutz commented Jan 19, 2019

Well the README, RELEASE_NOTES, NOTICE and DISCLAIMER don't have those for us, but all the other files do. It's still a product of your project documentation isn't much different than code and should have headers in them (my personal oppinion).

I wasn't opposed by excluding the root README file, I was just opposed by generally excluding markdown files.

@jixuan1989
Copy link
Member Author

jixuan1989 commented Jan 20, 2019

Well the README, RELEASE_NOTES, NOTICE and DISCLAIMER don't have those for us, but all the other files do. It's still a product of your project documentation isn't much different than code and should have headers in them (my personal oppinion).

I wasn't opposed by excluding the root README file, I was just opposed by generally excluding markdown files.

  • All MardDown files (except for .github/**/*.md which are generated by Github for describing issues and others' templates) are added the ASF header.
  • I comment the license-maven-plugin, and add a comment to say that we do not recommend to use it for avoiding out-of-control.

MyXOF
MyXOF approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@MyXOF MyXOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jixuan1989 jixuan1989 merged commit 5a11aae into master Jan 21, 2019
@Beyyes Beyyes deleted the fix_license branch January 22, 2019 02:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 31, 2021

SonarCloud Quality Gate failed.

Bug E 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 96 Code Smells

0.7% 0.7% Coverage
20.9% 20.9% Duplication

warning The version of Java (1.8.0_282) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@sunjincheng121 sunjincheng121 mentioned this pull request Mar 26, 2021
Merged
mzp0514 pushed a commit to mzp0514/iotdb that referenced this pull request Apr 26, 2021
@HTHou @mzp0514
# This is a combination of 15 commits.
ba96917 
# This is the 1st commit message:

Fix query one sensor in a vector from memtable (apache#3056)

Fix query one sensor in a vector from memtable
# This is the commit message apache#2:

[IOTDB-1310] Enable docker, docker-compose and testcontainer for End to end test (apache#3024)

* enable TestCongtainer for E2E test for (singleNode and cluster)

* remove duplicated operations in integration-test phase

* move spotless:apply to a profile `spotless`, which is enabled by default.

Co-authored-by: xiangdong huang <sainthxd@gmail.com>
# This is the commit message apache#3:

add sink interface

# This is the commit message apache#4:

3 new event sinks

# This is the commit message apache#5:

add ts sink

# This is the commit message apache#6:

add ts sink

# This is the commit message apache#7:

add mqtt sink

# This is the commit message apache#8:

refactor sink module

# This is the commit message apache#9:

init package sink.manager

# This is the commit message apache#10:

rename SinkException

# This is the commit message apache#11:

remove id in config

# This is the commit message apache#12:

fix doc

# This is the commit message apache#13:

add test framework

# This is the commit message apache#14:

add alertmanager sink & test & doc

# This is the commit message apache#15:

beautify the doc
mychaow pushed a commit that referenced this pull request Dec 13, 2021
@neuyilan
amend the auto-tuning strategy to make it easier to understand (#4)
2319482
@xufwind95 xufwind95 mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MyXOF MyXOF MyXOF approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jixuan1989 @chrisdutz @MyXOF